search

Krealle / Cell_UnitFrames

MIT License
12 stars 3 forks source link

[Bug] Custom text & Health Text have different z-layers with respect to the shield overlay #174

Closed michaelbull closed 1 week ago

michaelbull commented 1 week ago

Addon Version

1.4.8

World of Warcraft Version

Retail

Describe the bug

When using custom texts, the custom text correctly draws above the shield texture. As of 1.4.8, the default Health Text now incorrectly draws beneath the shield texture.

Below is a picture displaying the problem, whereby the text at the top is the custom text (correct), and the text at the bottom is the health (incorrect).

image

Steps to reproduce

Enable both a custom text and the default text on the player unit frame.

BugSack

No response

Krealle commented 1 week ago

Can this be resolved by increasing the framelevel in widget setting?

michaelbull commented 1 week ago

Unfortunately not, even with a frame level of 100 in the Health Text setting, it still appears underneath the shield overlay.

Furthermore, this is the default installation, so I have not intentionally done any custom frame levels, so right now my default insllation of this addon has health text drawing underneath the shield overlay.

Krealle commented 1 week ago

Hmm, I'll take a look at it tomorrow then

Krealle commented 1 week ago

Image Image Changing the framelevel for me fixes that issue, are you certain you tried changing the proper framelevel?

michaelbull commented 1 week ago

I was changing the level of the Health Text, not the Shield Bar, and it was not working, however I've now started changing the Shield Bar's frame level and confirm it fixes it.

However, I would highlight that this behaviour has changed from a previous version. By default both the Health Text & Shield Bar had a frame level of 10, and before yesterday the text was drawing above the texture, whereas with 1.4.8 onwards it was not the case.

I think that if they both remain at 10 by default and now the health text is underneath the shield texture, this will continue to catch people out going forwards, so your solution does indeed fix it but I suspect somebody else will hit this too.

Thanks for your help diagnosing the issue so far.

Krealle commented 1 week ago

Hmm it worked fine for me when changing frame level of the text as well - will update the default values so they don't clash.