search

KreativJos / csharpextensions

C# Extensions for Visual Studio Code
MIT License
73 stars 35 forks source link

Do not highlight '.cs' extension when prompting for new class (etc.) … #42

Closed forrcaho closed 3 years ago

forrcaho commented 3 years ago

…name

Maybe I should have opened an issue for this first, but one thing I wanted to fix about this extension is that when prompting for a new class (or interface etc) name, the entire prompt filename "newclass.cs" is selected, forcing me to either retype the .cs extension or (worse) play with the mouse to fix the selection before typing in the new class name.

I hope you'll agree this is a desirable behavior; please label this PR 'hacktoberfest-accepted' if you do, as it's that stupid contest that inspires me to get in fixes like this.

KreativJos commented 3 years ago

Seems fine to me, but did you know that the extension puts an .cs to the end of the filename if it is missing? If you input NewClass, the created file will be NewClass.cs. If you input NewClass.txt, NewClass.txt.cs. Still, your solution seems better to me compared to removing the .cs-part.

forrcaho commented 3 years ago

Oh, I had no idea that the extension would add ".cs"; I've been retyping it constantly. At least with my extension it's clear what the behavior is. I guess it's a little less convenient when you want to use another extension, but that's a rare case.

forrcaho commented 3 years ago

I hate to bug you about this, but do you think you can label this PR 'hacktoberfest-accepted' ? When looking at the PR page, click on 'Labels' on the right hand column and enter hacktoberfest-accepted. Then click on "create new label" just below the text box. Then you have to click on labels again to add the new label from the list.

No need, but I'd be very happy if you went to the trouble to do this.