KreativJos / csharpextensions

C# Extensions for Visual Studio Code
MIT License
73 stars 35 forks source link

Added release workflow #74

Closed bard83 closed 2 years ago

bard83 commented 2 years ago

Enabled build, automatic CHANGELOG update and publish artifact. Close #55.

bard83 commented 2 years ago

@KreativJos In some cherry picked commits, some classes have been changed (codeActionProvider.ts and extension.ts). It should be checked whether it has been introduced a regression.

KreativJos commented 2 years ago

All seems correct to me, thank you for adding this! The only thing I'd like to change is the correct way of using semantic versioning:

bard83 commented 2 years ago

All changes addressed

KreativJos commented 2 years ago

Hmm, I'll have to figure out why the script doesn't work in the release: https://github.com/KreativJos/csharpextensions/runs/6064055532?check_suite_focus=true

bard83 commented 2 years ago

Probably the check out refers to branch main and not to master.

Here: https://github.com/KreativJos/csharpextensions/blob/cbe11809ff9d9aee9351e26e81dc5571a4fc525a/.github/workflows/release.yml#L19

Here: https://github.com/KreativJos/csharpextensions/blob/cbe11809ff9d9aee9351e26e81dc5571a4fc525a/.github/workflows/release.yml#L30