KreativJos / csharpextensions

C# Extensions for Visual Studio Code
MIT License
74 stars 34 forks source link

refactor: :fire: Removed initializeMemberFromCtor command #93

Closed KreativJos closed 1 year ago

KreativJos commented 2 years ago

initializeMemberFromCtor is provided by the C# extension (omnisharp)

75

KreativJos commented 2 years ago

Don't know about versioning with this, but I do not think it really matters. I don't expect anyone to have an issue with this, because the feature is included in the default C# extension.

bard83 commented 2 years ago

It won't matter exactly for the reason you mentioned. Probably redundancy should be considered as a bug. Omnisharp has an higher priority/consideration compared to the extension.

bard83 commented 2 years ago

Don't know about versioning with this, but I do not think it really matters. I don't expect anyone to have an issue with this, because the feature is included in the default C# extension.

I've miss understood on the first round, I guess that your retro-compatibility concern is more related to the following situation: the user does not have the specific C# extension version - where the initialization feature for ctor exists - but it gets this change -> the user might loose the feature because none provides it. Possible approaches:

To me the second could be the correct decision, don't know if it's technically doable.