Closed vilanovi closed 9 years ago
Hi Joan,
Thanks for feedback, good to hear you've found it useful. I will certainly look at pulling your changes into my repository. I've had a quick look through what you've done and it all looks good. I need to go through it a bit more detail, and will get back to you if I can think of anything that needs changing.
I've added a bug issue to cover the remaining bug you've reported. That's certainly something that would be good to fix, although hopefully the rendering is good enough for most uses.
Regards,
Matt
Hello,
We are using the KILabel class in our organisation projects. However we have refracted the interface of the KILabel class: added documentation, unified the KILinkDetectorType with the KILinkType, add getters and setters for each link type text attributes, added support for ignore keywords, and a few changes more.
Regarding bugs:
[@"string" boundingRectWithSize:options:attributes:context:]
(as UILabel does). I have to study a bit more why this is happening and how to prevent it.I don't know if you might be interested in merge our fork in your repository, in any case, I offer you a pull request and is your call to decide if you are interested or not.
Also, if you feel we must add/change something else, please, tell me and we will do it.
Thanks,
Joan