Kreolix / CovenantMissionHelper

10 stars 8 forks source link

SetJustifyV("CENTER") should be "MIDDLE" #71

Open SpareSimian opened 5 months ago

SpareSimian commented 5 months ago

As the title says. There are two spots in UI.lua to fix. This started with 10.2.7 today.

SpareSimian commented 5 months ago

It's possible this is a transient Blizzard bug. I just reverted my fix to see if I could reproduce it and now can't, but there's been a client update since then. I'll close this if I don't see it again over the next few days.

SpareSimian commented 5 months ago
Date: 2024-05-08 11:41:14
ID: 1
Error occured in: Global
Count: 1
Message: Interface/AddOns/CovenantMissionHelper/UI.lua line 96:
   bad argument #1 to 'SetJustifyV' (Usage: self:SetJustifyV(justifyV))
Debug:
   [string "=[C]"]: SetJustifyV()
   [string "@Interface/AddOns/CovenantMissionHelper/UI.lua"]:96:
      Interface/AddOns/CovenantMissionHelper/UI.lua:84
   [string "@Interface/AddOns/CovenantMissionHelper/UI.lua"]:315: createMissionHelperFrame()
   [string "@Interface/AddOns/CovenantMissionHelper/CovenantMissionHelper.lua"]:31:
      ...dOns/CovenantMissionHelper/CovenantMissionHelper.lua:26
Locals:
(*temporary) = FontString {
 0 = <userdata>
}
(*temporary) = "CENTER"

Solution found here. It's for Cata Classic but works for Retail. https://gitlab.com/norganna-wow/auctioneer/auctioneer/-/issues/45

SpareSimian commented 5 months ago

My bad. There's only the one call to fix. (I had to fix it in several addons I use.) So just line 96.

fubaWoW commented 2 months ago

temporary fix until pullrequest https://github.com/Kreolix/CovenantMissionHelper/pull/73 merged https://github.com/fubaWoW/CovenantMissionHelper