Closed AAA3A-AAA3A closed 2 years ago
Thanks for looking to contribute. As you can see, I've added the November milestone to your PR. This means I'll try and get onto it in the month of November, although I must take my exams first.
Please run pre-commit on the necessary files.
I have made all the changes you suggested. Should I use black on the files? Thanks you in advance.
Yes, please run black again on those changes
I just tested everything. Everything works and no errors on the console. Before using black on it, I test against a bot and a user at the same time.
I have another idea which I may do when I have finished my own cog in progress. It would be to allow another setting that would allow a server owner to challenge someone who "looks" like a bot without necessarily testing everyone at their entrance.
I reformatted the only file that had been modified using black and isort. It's fine.
I have changed my PR a lot. For the "[p]captcha" command, it will send an error message if the challenge already exists, rather than aborting everything. Then I added a "[p]skipcaptcha" command which, as the name suggests, will stop a captcha challenge for the specified user(s). I will make the PR change soon. What do you think of it?
Hello, I made all the requested changes, tested everything and ran isort and black on it. Everything is good. Any other modification ? Thanks in advance.
please run black on your recent changes
There's also undefined variables everywhere, I do not believe you have tested this. Please go away and test it properly
I had already spent black and isort on it. You can see that I have uploaded again. I really tested the commands and they work. I didn't go any further. I'll look at the undefined variables.
All undefined variables are corrected. That's all right. I ran black and isort on it.
Unfortunately I have come to the decision that I would not like to see this feature merged into master. With dpy2 on the horizon, I'd much rather focus on fundamental implementation than feature ideas. You may maintain your own fork so that you can continue using these new commands for your instance of Red. Thank you very much for your willingness to contribute, and for your time dedicated to this PR.
Type
Description of the changes
Hello, Here is the code to add the functionality to manually launch the captcha challenge for the specified user(s). Simply issue the command "[p]captcha @user @user1 etc.". Thanks in advance and have a nice day.