search

Kreyu / data-table-bundle

Streamlines creation process of the data tables in Symfony applications. NOT PRODUCTION READY.
https://data-table-bundle.swroblewski.pl
MIT License
69 stars 15 forks source link

[Bug] Using undefined targets in the batch script #109

Closed alexandre-castelain closed 2 months ago

alexandre-castelain commented 2 months ago

Using the "tabler" or "base" theme leads to a script crash.

I'm not sure if we should add those targets to the themes, it could be better.

Kreyu commented 2 months ago

Hey! Not sure what's the problem with Tabler theme, since the targets seem to be present in the HTML. Are you sure you're not overriding any part of the theme?

The base theme is so minimal and unusable by itself, that sometimes I wonder whether it is worth including it in the bundle 😄

But adding those conditions to the script will make it more flexible though, thanks for the contribution.

alexandre-castelain commented 2 months ago

You're right, there's not problem with the tabler theme. I don't use it, so I thought it was extending the base theme, but it's the bootstrap one. So no problem with the tabler theme, only with the base one ! :)

In my opinion, the base theme is excellent as it is, because it's a good base to create your custom theme !