search

Kreyu / data-table-bundle

Streamlines creation process of the data tables in Symfony applications. NOT PRODUCTION READY.
https://data-table-bundle.swroblewski.pl
MIT License
75 stars 14 forks source link

fix: Doctrine ORM result set looping on the past page #77 #78

Closed Kreyu closed 6 months ago

Kreyu commented 6 months ago

References issue described in #77

The DoctrineOrmResultSetFactory class, responsible for creating a result set and its iterator, was incorrectly setting the query's first result (offset), which introduced a bug visible on the last page of results.

For example, if last page contains 22 rows, but each page displays 25 max, the factory would (incorrectly) iterate one more time, adding another 25 rows, starting from offset of 22 records.

cloudflare-workers-and-pages[bot] commented 6 months ago

Deploying data-table-bundle with  Cloudflare Pages  Cloudflare Pages

Latest commit: e66792e
Status: ✅  Deploy successful!
Preview URL: https://001c82f9.data-table-bundle.pages.dev
Branch Preview URL: https://result-set-looping-issue-77.data-table-bundle.pages.dev

View logs