Kris-B / nanoGALLERY

image gallery simplified - jQuery plugin. Touch enabled, responsive, justified/cascading/grid layout and it supports pulling in Flickr, Google Photos and self hosted images.
https://nanogallery2.nanostudio.org/
439 stars 101 forks source link

Script errors in requirejs app #40

Closed jefftmills closed 9 years ago

jefftmills commented 9 years ago

Loaded into our RequireJS app., the gallery causes a network 404 error trying to load http://localhost/javascripts/ngeventEmitter/ngEventEmitter.js".

The AMD loading in jquery.nanogallery.js requires 'ngeventEmitter/ngEventEmitter' but elsewhere in the file the dependency is defined as 'ngEventEmitter/ngEventEmitter' (notice the upper case 'E' as the 3rd character).

My work-around is to add a mapping to my requirejs config:

map: {
  '*': {
    'ngeventEmitter/ngEventEmitter': 'ngEventEmitter/ngEventEmitter'
  }
}
Kris-B commented 9 years ago

I'm currently on holidays... I'll fix this in a couple of days. Thanks for the report. Le 20 août 2014 00:57, "Jeff Mills" notifications@github.com a écrit :

Loaded into our RequireJS app., the gallery causes a network 404 error trying to load http://localhost/javascripts/ngeventEmitter/ngEventEmitter.js".

The AMD loading in jquery.nanogallery.js requires 'ngeventEmitter/ngEventEmitter' but elsewhere in the file the dependency is defined as 'ngEventEmitter/ngEventEmitter' (notice the upper case 'E' as the 3rd character).

My work-around is to add a mapping to my requirejs config:

map: { '*': { 'ngeventEmitter/ngEventEmitter': 'ngEventEmitter/ngEventEmitter' } }

— Reply to this email directly or view it on GitHub https://github.com/Kris-B/nanoGALLERY/issues/40.

Kris-B commented 9 years ago

fixed in v5.1.0