search

Kris-B / nanoGALLERY

image gallery simplified - jQuery plugin. Touch enabled, responsive, justified/cascading/grid layout and it supports pulling in Flickr, Google Photos and self hosted images.
https://nanogallery2.nanostudio.org/
439 stars 101 forks source link

Scroll images locked after open / close image #53

Closed Altuk closed 9 years ago

Altuk commented 9 years ago

Hello Kris, I noticed a problem, also visible on "http://nanogallery.brisbois.fr/#features" selecting eg "Justified Layout", in your demo there are so many images so initially block scroll regularly.

Then, when I click on a photo, she zooms in, then I close, at this point I can no longer scroll the view. This is a problem if the gallery contains many photos, to "unlock" it is necessary to reload the page.

Looking at the error console on Chrome or Firefox, I noticed an object "undefined", I am attaching a screenshot. schermata 2014-10-24 alle 22 47 28

Thanks.

Kris-B commented 9 years ago

Hi, can you please try to reprocude again this behaviour on the demo page? Thanks.

Altuk commented 9 years ago

Perfect, now works correctly! Which file should I update to resolve?

Thanks!

msgordon commented 9 years ago

I can report similar behavior. Closing an image does not return the scrollbar to the webpage on chrome/firefox. As a temporary work-around, I added ScrollbarSetVisible(); to the end of function CloseInternalViewer() in my working copy.

Kris-B commented 9 years ago

@Altuk : just install v5.2.2 ;-) @msgordon : an incorrect test condition before ScrollbarSetVisible(); was causing the issue. It's corrected in v5.5.2

Kris-B commented 9 years ago

@Altuk @msgordon : just to inform you that the fix is not working in some cases. I'm still investigating.

Kris-B commented 9 years ago

fixed in v5.2.3