Kris-B / nanoGALLERY

image gallery simplified - jQuery plugin. Touch enabled, responsive, justified/cascading/grid layout and it supports pulling in Flickr, Google Photos and self hosted images.
https://nanogallery2.nanostudio.org/
439 stars 101 forks source link

ThumbnailL1 issue? #97

Closed klous-1 closed 8 years ago

klous-1 commented 8 years ago

Hi Christophe,

I'm not sure but it looks to me like there is some issue with thumbnailL1Height/Width. The thumbs are not displaying correctly, just small slits (may depend on settings/sizes used).

I've just updated from v5.4 to 5.9, and then also tried an old jsfiddle of yours which has v5.7. v5.4 is/was working fine, but 5.7 and 5.9 seem to have this issue.

Check out the updated fiddle here which shows the problem: http://jsfiddle.net/99xLegdk/

klous-1 commented 8 years ago

OK, it seems to be a problem with 'auto' option in combination with thumbnailL1 settings....oddly the Level 1 images display okay. Take out auto or L1 setting and it works okay.

Kris-B commented 8 years ago

Hey! Actually it is an issue with 'auto' and Picasa storage. The 'auto' value implies the thumbnail image size (width and height) to be known. But the Picasa/Google+ API returns incorrect values for the first level (albums). So nG needs to wait until the thumbnail images are loaded to retrieve their correct size and then the layout can be rendered.

So long for the method...

I check the fiddle http://jsfiddle.net/99xLegdk/ : I see the small slits and after a small delay, thumbnails are displayed correctly.

In your case : the small slits are never replaced by the correct thumbnails?

klous-1 commented 8 years ago

Level1 is okay (albums) but it is the photos within the albums which is the problem....slits remain permanently, in the fiddle too (it's not like this for you?).

Like I say, v5.4 was no problem and my gallery is fine with this version, so something has changed.(http://www.talesfromthesaddle.com/photos)

Kris-B commented 8 years ago

ok, found this issue. please check v5.9.1

klous-1 commented 8 years ago

Thanks Christophe! Works a treat now! :+1:

Kris-B commented 8 years ago

;-)