KrisCris / AllStackable

A highly customizable Minecraft Fabric Mod that makes items stackable and changes their stack size.
https://www.curseforge.com/minecraft/mc-mods/all-stackable/
GNU Lesser General Public License v3.0
13 stars 7 forks source link

1.20 support? #57

Closed allanonmage closed 1 year ago

allanonmage commented 1 year ago

I'm checking on the mods I've included in my modpack to see where development is. I told my players that it might be several months after 1.20 is released before all our mods are updated. Will you be updating your mod? Do you have an ETA when you will be adding support for the later versions?

chimericdream commented 1 year ago

@KrisCris I forked the repo and updated it to 1.20.1. I did some basic testing, and it seems to work as expected. Since I made a new 1.20 branch, GitHub won't let me make a PR (I'd need to create a PR to 1.19 or another older branch). However, if you want to take my changes, it was pretty minimal.

I saw the note on your readme about not planning to continue maintaining this beyond another version or two. If you are ok with it, I would be interested in continuing it as a new project starting with 1.20 (with obvious credits to you for the original mod).

Whatever you decide regarding the future of the mod, here is the branch where I made my changes. Thanks!

https://github.com/chimericdream/AllStackable/tree/1.20

KrisCris commented 1 year ago

Hi @chimericdream,

Thanks for your interest in the mod and for taking the initiative to maintain it! I had plans to rewrite it at some point, but due to personal circumstances, I won't be able to do so in the foreseeable future :/

You're more than welcome to take over the mod and continue its development. Additionally, if you're interested, I can add you to the current project page on both CurseForge and Modrinth. This way, you can upload new versions directly. If this is something you'd like to do, just let me know your username ;)

chimericdream commented 1 year ago

My profile on CurseForge is chimericdream, and Modrinth is connected to my GitHub account. I can't promise I'll have time every Minecraft release (who can?), of course, but I am happy to help when I can!

KrisCris commented 1 year ago

My profile on CurseForge is chimericdream, and Modrinth is connected to my GitHub account. I can't promise I'll have time every Minecraft release (who can?), of course, but I am happy to help when I can!

No worries at all, just take it at your own pace and decide when you want to work on the mod. I really appreciate that you got it working on 1.20! By the way, I just added your account to the project page ;)

chimericdream commented 1 year ago

I am uploading a new version for 1.20.1 now!

chimericdream commented 1 year ago

This can be closed. 1.20.1 is released! https://www.curseforge.com/minecraft/mc-mods/all-stackable/files/4653863