KrisCris / AllStackable

A highly customizable Minecraft Fabric Mod that makes items stackable and changes their stack size.
https://www.curseforge.com/minecraft/mc-mods/all-stackable/
GNU Lesser General Public License v3.0
13 stars 7 forks source link

Minecraft 1.21.3 Support #68

Open sternschnaube opened 6 months ago

sternschnaube commented 6 months ago

java.lang.RuntimeException: Mixin transformation of net.minecraft.class_2275 failed at net.fabricmc.loader.impl.launch.knot.KnotClassDelegate.getPostMixinClassByteArray(KnotClassDelegate.java:427) at net.fabricmc.loader.impl.launch.knot.KnotClassDelegate.tryLoadClass(KnotClassDelegate.java:323) at net.fabricmc.loader.impl.launch.knot.KnotClassDelegate.loadClass(KnotClassDelegate.java:218) at net.fabricmc.loader.impl.launch.knot.KnotClassLoader.loadClass(KnotClassLoader.java:119) at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:526) at java.base/java.lang.ClassLoader.defineClass1(Native Method) at java.base/java.lang.ClassLoader.defineClass(ClassLoader.java:1027) at java.base/java.security.SecureClassLoader.defineClass(SecureClassLoader.java:150) at net.fabricmc.loader.impl.launch.knot.KnotClassLoader.defineClassFwd(KnotClassLoader.java:160) at net.fabricmc.loader.impl.launch.knot.KnotClassDelegate.tryLoadClass(KnotClassDelegate.java:355) at net.fabricmc.loader.impl.launch.knot.KnotClassDelegate.loadClass(KnotClassDelegate.java:218) at net.fabricmc.loader.impl.launch.knot.KnotClassLoader.loadClass(KnotClassLoader.java:119) at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:526) at net.minecraft.class_2358.method_10199(class_2358.java:336) at net.minecraft.class_2966.method_12851(class_2966.java:53) at net.minecraft.client.main.Main.main(Main.java:170) at net.fabricmc.loader.impl.game.minecraft.MinecraftGameProvider.launch(MinecraftGameProvider.java:470) at net.fabricmc.loader.impl.launch.knot.Knot.launch(Knot.java:74) at net.fabricmc.loader.impl.launch.knot.KnotClient.main(KnotClient.java:23) Caused by: org.spongepowered.asm.mixin.transformer.throwables.MixinTransformerError: An unexpected critical error was encountered at org.spongepowered.asm.mixin.transformer.MixinProcessor.applyMixins(MixinProcessor.java:392) at org.spongepowered.asm.mixin.transformer.MixinTransformer.transformClass(MixinTransformer.java:234) at org.spongepowered.asm.mixin.transformer.MixinTransformer.transformClassBytes(MixinTransformer.java:202) at net.fabricmc.loader.impl.launch.knot.KnotClassDelegate.getPostMixinClassByteArray(KnotClassDelegate.java:422) ... 18 more Caused by: org.spongepowered.asm.mixin.throwables.MixinApplyError: Mixin [allstackable.mixins.json:MixinCauldronBlock from mod allstackable] from phase [DEFAULT] in config [allstackable.mixins.json] FAILED during APPLY at org.spongepowered.asm.mixin.transformer.MixinProcessor.handleMixinError(MixinProcessor.java:638) at org.spongepowered.asm.mixin.transformer.MixinProcessor.handleMixinApplyError(MixinProcessor.java:589) at org.spongepowered.asm.mixin.transformer.MixinProcessor.applyMixins(MixinProcessor.java:379) ... 21 more Caused by: org.spongepowered.asm.mixin.injection.throwables.InvalidInjectionException: Critical injection failure: @Inject annotation on cleanStackedShulkerBox could not find any targets matching 'Lnet/minecraft/class_2275;method_9534(Lnet/minecraft/class_2680;Lnet/minecraft/class_1937;Lnet/minecraft/class_2338;Lnet/minecraft/class_1657;Lnet/minecraft/class_1268;Lnet/minecraft/class_3965;)Lnet/minecraft/class_1269;' in net.minecraft.class_2275. Using refmap AllStackable-refmap.json [PREINJECT Applicator Phase -> allstackable.mixins.json:MixinCauldronBlock from mod allstackable -> Prepare Injections -> -> handler$zzi000$allstackable$cleanStackedShulkerBox(Lnet/minecraft/class_2680;Lnet/minecraft/class_1937;Lnet/minecraft/class_2338;Lnet/minecraft/class_1657;Lnet/minecraft/class_1268;Lnet/minecraft/class_3965;Lorg/spongepowered/asm/mixin/injection/callback/CallbackInfoReturnable;)V -> Parse] at org.spongepowered.asm.mixin.injection.struct.InjectionInfo.validateTargets(InjectionInfo.java:658) at org.spongepowered.asm.mixin.injection.struct.InjectionInfo.findTargets(InjectionInfo.java:589) at org.spongepowered.asm.mixin.injection.struct.InjectionInfo.readAnnotation(InjectionInfo.java:330) at org.spongepowered.asm.mixin.injection.struct.InjectionInfo.(InjectionInfo.java:316) at org.spongepowered.asm.mixin.injection.struct.InjectionInfo.(InjectionInfo.java:308) at org.spongepowered.asm.mixin.injection.struct.CallbackInjectionInfo.(CallbackInjectionInfo.java:46) at java.base/jdk.internal.reflect.DirectConstructorHandleAccessor.newInstance(DirectConstructorHandleAccessor.java:62) at java.base/java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:502) at java.base/java.lang.reflect.Constructor.newInstance(Constructor.java:486) at org.spongepowered.asm.mixin.injection.struct.InjectionInfo$InjectorEntry.create(InjectionInfo.java:149) at org.spongepowered.asm.mixin.injection.struct.InjectionInfo.parse(InjectionInfo.java:710) at org.spongepowered.asm.mixin.transformer.MixinTargetContext.prepareInjections(MixinTargetContext.java:1329) at org.spongepowered.asm.mixin.transformer.MixinApplicatorStandard.prepareInjections(MixinApplicatorStandard.java:1053) at org.spongepowered.asm.mixin.transformer.MixinApplicatorStandard.applyMixin(MixinApplicatorStandard.java:395) at org.spongepowered.asm.mixin.transformer.MixinApplicatorStandard.apply(MixinApplicatorStandard.java:327) at org.spongepowered.asm.mixin.transformer.TargetClassContext.apply(TargetClassContext.java:422) at org.spongepowered.asm.mixin.transformer.TargetClassContext.applyMixins(TargetClassContext.java:403) at org.spongepowered.asm.mixin.transformer.MixinProcessor.applyMixins(MixinProcessor.java:363) ... 21 more

TheRonGDD commented 4 months ago

@KrisCris This is the best stack editing mod out there. Is there any chance this will be updated? There is no realistic alternative out there as of now.

sternschnaube commented 4 months ago

I hope so 😄

bohicars commented 4 months ago

please say you are updating this to 1.21, it is amazing and love the configurability of it! and its so easy to use!

icedegreaser commented 4 months ago

yes please

PhantomRuffy commented 2 months ago

this would be amazing

tropicthedev commented 1 month ago

I do have a working version of 1.21 BUT there are some bugs im trying to figure out, if @KrisCris would like the patch still I would be happy to provide it in a PR. Going to fork the project and then add the code there in the meantime.

KrisCris commented 1 month ago

I do have a working version of 1.21 BUT there are some bugs im trying to figure out, if @KrisCris would like the patch still I would be happy to provide it in a PR. Going to fork the project and then add the code there in the meantime.

Yes please, thank you for the support!

tropicthedev commented 1 month ago

I do have a working version of 1.21 BUT there are some bugs im trying to figure out, if @KrisCris would like the patch still I would be happy to provide it in a PR. Going to fork the project and then add the code there in the meantime.

Yes please, thank you for the support!

Ok I have added the code to this PR #70

KrisCris commented 1 month ago

For anyone interested, this is the download link for the dev build based on @tropicthedev's fix. https://github.com/KrisCris/AllStackable/actions/runs/11063712281/artifacts/1985566584

sternschnaube commented 1 month ago

Tested the build now, works! Thank you both 😄

KrisCris commented 1 month ago

Any feedback on this build is appreciated! https://github.com/KrisCris/AllStackable/actions/runs/11233241525

sternschnaube commented 1 month ago

I was trying the new build with stack size up to 99. Changed my configuration file and put everything to 99. Seems to load from the console output.

image

Now on the server, I can't stack up to 99, re-joining the world doesn't help.

I have to set the stack size again with command and re-join the server, then I can refresh my inventory with the stacksize. Otherwise everything works!

KrisCris commented 1 month ago

I was trying the new build with stack size up to 99. Changed my configuration file and put everything to 99. Seems to load from the console output.

Now on the server, I can't stack up to 99, re-joining the world doesn't help.

I have to set the stack size again with command and re-join the server, then I can refresh my inventory with the stacksize. Otherwise everything works!

I am not sure what's happening, were you modifying the stack size on the server? Cuz the stack size is always synced from the server side, i.e. per world config.

sternschnaube commented 1 month ago

Yep, I changed the config from the world folder. Replacing all "64" values with "99". But this seems not to work correctly. Using the command while you playing works.

sternschnaube commented 1 month ago

Armor cannot be stacked too.

image