KrisCris / Palworld-Pal-Editor

Palworld Pal Editor, the tool for Adding, Deleting, and Modifying Pals (and unlocking Viewing Cage for multiplayer) for Palworld Game Save, supports running on Docker, GUI, WebUI, and Cli.
https://www.nexusmods.com/palworld/mods/995
GNU General Public License v3.0
106 stars 11 forks source link

Palworld-Pal-Editor 0.4.1.post2 on PyPi missing WebUI assets #14

Closed imakin closed 2 months ago

imakin commented 2 months ago

Hi Thank you for the application.

However the pip and the latest main branch version doesnt work. it shows error 404 page. image

how to reproduce

    pip install palworld-pal-editor
    python -m palworld_pal_editor

i notice the the assets are placed in this folder frontend/palworld-pal-editor-webui ? but that folder is not the one pointed by the static_folder_path = Path(app.static_folder) in webui.py

running the docker version also fails, got "The connection was reset" on the browser image

docker/docker-compose.yml file:

    version: '3.8'
    services:
      palworld-pal-editor:
        image: docker.io/library/palworld-pal-editor
        container_name: palworld-pal-editor
        # network_mode: host
        ports:
          - 12345:12345
        environment:
          - TZ=UTC
          - PUID=1000
          - PGID=1000
          - APP_PORT=12345 # make sure this matches the port you are going to map
          - APP_LANG=en-US
          - MODE=web # [cli, web, gui] You are not going to run gui in docker though... ;)
          - SAVE_PATH=/mnt/gamesave
          - PASSWORD=password # remove this env unless you want a password, but password is strongly recommended (for web mode).
        volumes:
          - "/tmp:/mnt/gamesave"
KrisCris commented 2 months ago

Hmm, this is weird.

FYI, the WebUI is built and copied to the app.static_folder location

KrisCris commented 2 months ago

Can confirm this issue with the latest pypi published version.

Meanwhile, you can use the older version pip install palworld-pal-editor==0.4.1.

KrisCris commented 2 months ago

Fixed.

try --upgrade or pip install palworld-pal-editor==0.4.1.post2

KrisCris commented 2 months ago

As for the Docker, you will need to wait a while for the first launch before opening the webpage.