Add ja translations for new passive skills and condenser rank

KrisCris / Palworld-Pal-Editor

Palworld Pal Editor, the tool for Adding, Deleting, and Modifying Pals (and unlocking Viewing Cage for multiplayer) for Palworld Game Save, supports running on Docker, GUI, WebUI, and Cli.

https://www.nexusmods.com/palworld/mods/995

GNU General Public License v3.0

106 stars 11 forks source link

Add ja translations for new passive skills and condenser rank #25

Closed Take-Me1010 closed 2 months ago

Take-Me1010 commented 2 months ago

Hi, it's been while 👍 Thank you for your frequent update and continuous maintanace.

In this PR, I added some japanese translations for new passive skills (added in recent update) and condenser rank in GUI. I did not modify any other modification affecting main logic of this tool.

KrisCris commented 2 months ago

Lgtm, thank you again for helping with the translation!

KrisCris commented 2 months ago

Awesome, let me know if this is ready to be merged.

Take-Me1010 commented 2 months ago

I added more Japanese translations. Here are some points:

"ベースキャンプ" should be translated as "拠点" in the game context.
"計算された" seems redundant.
"個体値" is originally pokemon term but frequently, commonly used. Instead, "才能" is used in the game. I listed both of them.

Take-Me1010 commented 2 months ago

Awesome, let me know if this is ready to be merged.

Yes, that's all for this PR.

KrisCris commented 2 months ago

"計算された" seems redundant.

Agreed, but I am not sure how to phrase it properly. I put the term here because I want users to know that these values may or may not match the value in-game since the formulas aren't perfect.

Take-Me1010 commented 2 months ago

"計算された" seems redundant.

Agreed, but I am not sure how to phrase it properly. I put the term here because I want users to know that these values may or may not match the value in-game since the formulas aren't perfect.

Indeed, it is better for users to be able to distinguish them at a glance. Then, I suggest "実数値" instead. "実数値" corresponds "actual value" in Japanese. "計算された最大HP" -> "最大HP実数値" "計算された攻撃力" -> "攻撃力実数値" "計算された防御力" -> "防御力実数値"

"実数値" is widely used in the pokemon context in order to distinguish talent and actual status value, so many user can understand what the value means, I believe.

Take-Me1010 commented 2 months ago

Sorry, I misunderstood your intent. I will try to think of a few corresponding expressions.

Take-Me1010 commented 2 months ago

Instead of "計算された" (computed), I suggest using "推定" (estimated) as follows:

    Editor_12: "推定最大HP: ",
    Editor_13: "推定攻撃力: ",
    Editor_14: "推定防御力: ",
    Editor_15: "推定クラフト速度: ",

Ideally, implementaion of some tooltips helps users to understand your intent.

KrisCris commented 2 months ago

Instead of "計算された" (computed), I suggest using "推定" (estimated) as follows:
    Editor_12: "推定最大HP: ",
    Editor_13: "推定攻撃力: ",
    Editor_14: "推定防御力: ",
    Editor_15: "推定クラフト速度: ",
Ideally, implementaion of some tooltips helps users to understand your intent.

Yea, this sounds good. I am going to include it in the next update.