Add Japanese translation support - Githubissues

KrisCris / Palworld-Pal-Editor

Palworld Pal Editor, the tool for Adding, Deleting, and Modifying Pals (and unlocking Viewing Cage for multiplayer) for Palworld Game Save, supports running on Docker, GUI, WebUI, and Cli.

https://www.nexusmods.com/palworld/mods/995

GNU General Public License v3.0

106 stars 11 forks source link

Add Japanese translation support #6

Closed Take-Me1010 closed 3 months ago

Take-Me1010 commented 3 months ago

Thank you for your nice application.

I am Japanese. So I would like to controbute this project in the context of Japanese language support !

What I did

I added i18n data for Japanese.
I added a new choise ("日本語") for Japanese translation in TopBar.vue (which comes from the change of stores/paleditor.js)

I can't understand what corresponds to assets/data/gui_i18n.json. If the change of this file is incorrect, please tell me.

What I did NOT do

i18n data for "waza" (in pal_attacks.json)
- I will do, but I tentatively create this PR.
i18n data for "human" (in pal_data.json)
- I think many player don't refer them.

How to check

I run this application with Python 3.11.5 and npm 10.5.0 in windows 10. I confirmed that the new option "日本語" exists in the top bar and works well.

KrisCris commented 3 months ago

Looks good to me, thanks for your contribution!

I can't understand what corresponds to assets/data/gui_i18n.json.

Yeah, this file is unused and I've just deleted it.