Add Japanese translation for waza - Githubissues

KrisCris / Palworld-Pal-Editor

Palworld Pal Editor, the tool for Adding, Deleting, and Modifying Pals (and unlocking Viewing Cage for multiplayer) for Palworld Game Save, supports running on Docker, GUI, WebUI, and Cli.

https://www.nexusmods.com/palworld/mods/995

GNU General Public License v3.0

106 stars 11 forks source link

Add Japanese translation for waza #7

Closed Take-Me1010 closed 3 months ago

Take-Me1010 commented 3 months ago

Hi, thank you for your fast review and merge of #6 . Now I added Japanese translatin data for waza in pal_attacks.json.

By the way, I noticed some waza data is incorrect when editting. Here is the list:

l. 735 火/邪麒麟 -> 火麒麟 is correct. (I did NOT modify it)
l. 793 CT of EPalWazaID::ThunderBall may be 9, not 50. (I did NOT modify it)

As listed, this PR does NOT include these modification, because this PR focus on Japanese translation data.

What I did

add Japanese translatin data for waza in pal_attacks.json
modify pal name typo in pal_data.json for Japanese.

How to check

The dev enviroment is same as that of #6 . I comfirm that the waza list is properly translated in web mode and gui mode.

KrisCris commented 3 months ago

merged, thank you so much!