search

Krisell / gkk-anmalan

Göteborg Kraftsportklubb (GKK) Anmälningsweb
https://anmalan.gkk-styrkelyft.se
0 stars 1 forks source link

Create Dockerfile #64

Closed wilari932 closed 2 months ago

wilari932 commented 2 months ago

Please check if the docker file is correct before merge, im also using sqlite here instead of mysql

Krisell commented 2 months ago

This is awesome!

I rarely use Docker for local dev so I don't know all the nuances, but I created another PR which uses Laravel Sail, which is their first party Docker integration for local dev. Using that might simplify things over setting up a custom container. https://github.com/Krisell/gkk-anmalan/pull/65

I think that gives some additional features (e.g. everything setup for adding services via Docker-compose), as well as less code for us to maintain. See if that works for you.

I also always use sqlite locally and in tests.