Closed lukebfunk closed 2 years ago
coveralls
commented
3 years ago | Totals | |
|---|---|
| Change from base Build 556229105: | 0.0% |
| Covered Lines: | 0 |
| Relevant Lines: | 0 |
dburkhardt
commented
3 years ago @lukebfunk Can you lint the code using black and flake8?
lukebfunk
commented
3 years ago Great! I am new to lint-ing, but gave it a try. Feedback is welcome. Looks like flake8 should use --max-line-length 88 and ignore F401?
coveralls
commented
1 month ago This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
| Totals | |
|---|---|
| Change from base Build 556229105: | 0.0% |
| Covered Lines: | 0 |
| Relevant Lines: | 0 |
coveralls
commented
1 month ago This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
| Totals | |
|---|---|
| Change from base Build 556229105: | 0.0% |
| Covered Lines: | 0 |
| Relevant Lines: | 0 |
Currently anything that calls the
__repr__method of a PHATE class instance (__repr__is inherited from BaseEstimator) raises an error: e.g., anything likeprint(phate.PHATE())raisesAttributeError: 'PHATE' object has no attribute 'a'. This is due to the deprecatedabeing an argument of the__init__method, but not an attribute of the class instance. There are many ways this could be fixed; here I wrote a decorator for__init__that handles argument deprecation, removing deprecated arguments from__init__.