search

Krisiacik / ImageViewer

An image viewer à la Twitter
MIT License
2.53k stars 385 forks source link

Upgrade to Swift 5 #224

Closed jfahrenkrug closed 5 years ago

jfahrenkrug commented 5 years ago

I know there are already two other Swift 5 PRs. This one is based on Xcode 11 and also fixes the test target and a few extra things:

jfahrenkrug commented 5 years ago

Wow, awesome! Thanks for the quick turnaround @RuiAAPeres Can a new version of the Cocoapod be pushed out as well?

RuiAAPeres commented 5 years ago

@jfahrenkrug Might be worth adding the swift lang version in the podspec?

jfahrenkrug commented 5 years ago

@RuiAAPeres Yes, let me put up another PR.

jfahrenkrug commented 5 years ago

@RuiAAPeres Here it is: https://github.com/Krisiacik/ImageViewer/pull/225