search

Krisiacik / ImageViewer

An image viewer à la Twitter
MIT License
2.53k stars 385 forks source link

Added support as Swift Package #247

Open nobreak opened 4 years ago

nobreak commented 4 years ago

I had issues with Carthage and the new xcode12. It looks like that Carthage currently no more is usable with Xcode12 and iOS simulator. When you build the frameworks with 'carthage update' or 'carthage build' there comes an error. A deeper look says "have the same architectures (arm64) and can't be in the same fat output file" So the iOS Simulator build is missing in the framework. This already is discussed as issue here https://github.com/Carthage/Carthage/issues/3019 and here https://github.com/ashleymills/Reachability.swift/issues/370

My workarround was just to move from carthage to Swift Packages. I found out that is really easy to provide an existing iOS framework as Swift Package. Just create a fork of it, put there a configured Package.swift file into the root folder, double click it in finder to open it in Xcode as a SWIFT PACKAGE PROJECT !!! - now just add/change the path to the source files in the Package.swift file. When you could build the project, all is fine and push it to your repo - thats it. For this works.

Maybe you want to add Swift Package support ?

easydev991 commented 2 years ago

Can anybody merge this, please?

RuiAAPeres commented 2 years ago

@OlegEremenko991 does #246 solves your problem?

easydev991 commented 2 years ago

@OlegEremenko991 does #246 solves your problem?

Actually this PR is preferred, Package.swift is fixed in this branch (source location is invalid in #246)

RuiAAPeres commented 2 years ago

Can you re-open a new PR and only have changes related to the Package? I can see that there are changes to GalleryViewController.swift, which we can address somewhere else.

RuiAAPeres commented 2 years ago

cc @tc-sgupta