search

KristerV / heliumpay-budgetweb-backend

2 stars 2 forks source link

Separate routes from non-routing modules #9

Closed jschr closed 7 years ago

jschr commented 7 years ago

This is a proposal for moving core under a /routes directory to keep them separate from other api modules (ie. errors and middleware) that still need to be versioned.

I wasn't quite sure where to add upcoming routes likes register, login, etc... They didn't quite feel right under core or beside errors and middleware.

KristerV commented 7 years ago

Okay seems reasonable.

As I designed a while ago I thought there would be 4 types of routes = [core, masternodes, users, discussion]. Where Core is dash-cli commands.

No I realize v0/proposals/:hash should actually give you both the dash-cli result and also comments from the databse. So perhaps we need to redesign this..

Perhaps there is no need for core itself so mv core/raw/* core/? and the other routes can be purpose specific, like proposals and budget and users?

jschr commented 7 years ago

That makes sense to me!