search

KristhianX / essential-buttons-toolbar

Adds a toolbar to Android Firefox with essential buttons: Homepage, Duplicate Tab, New tab, Close tab and more.
GNU General Public License v3.0
30 stars 3 forks source link

Scroll To Top/Bottom Buttons Not Working on Gmail Mobile Website #37

Open Siva981 opened 1 month ago

Siva981 commented 1 month ago

Android & Device: Android 12 (Samsung Galaxy M01)

Firefox For Android: 130.0.1 (Latest Version available at the time of creating this issue)

Issue: The Scroll To Down/Top feature has stopped working on the Gmail mobile website. It was working flawlessly before.

Issue Page URL: https://mail.google.com/mail/mu/mp/465/#tl/Inbox

Possible Rootcause: Google recently made a change to the options bar at the top a few days ago. This bar (the one that says Inbox in the screenshots) is the one at the topmost of the page, which houses the Menu button on it's left corner & the red colored Compose button on it's right corner. When the page was scrolled down, this bar used to move up with the page (it got hidden or something?) and not appear again until we scroll to the top of the page again. But now, Google has made it such that this bar stays put when the rest of the page is scrolled down. Now it stays put even after opening an email. Previously the behavior was the same as that of the Inbox.

Note: All the other buttons of your EBTB Addon is still working on the Inbox page & the Email page. It is just the Scroll buttons that have stopped working.

Sreenshots:

1) Inbox Page

Screenshot_20240929-040252_Firefox

2) Email Page

Screenshot_20240929-042338_Firefox

KristhianX commented 2 weeks ago

Hi! Thanks for your detailed bug report, and sorry for the late reply. I’ve been quite busy with work, but I hope to find some time soon to make the necessary updates to the add-on.

The code for scrolling to the top and bottom of pages is simple and should work on most sites, but it depends on those sites having a traditional layout. Sites with different layouts or that make changes like the one you mentioned won’t work with that code. I’ll need to implement a different approach in such cases. I’ll keep you updated on any changes.

Thanks again for your feedback!

KristhianX commented 1 week ago

Hi! This has been fixed in the new 1.8.1 version. Thanks again for your feedback.

Siva981 commented 1 week ago

Hi,

This issue still persists on my Android 12 (Samsung Galaxy M01).

Do you need a screen recording? Or any other debug info that could help?

Thank you.

KristhianX commented 6 days ago

I think I know what is happening. I'll test another approach and let you know when it's ready.

KristhianX commented 3 days ago

Hi! The new update (1.8.2) is now available on AMO. Please test if the code is working properly after you receive the update. In my tests, it works as expected on the inbox page and in email view, but I haven't tested other views. Thank you for your feedback!

Siva981 commented 1 day ago

Hi,

Unfortunately, the results are still the same for me even after the version got updated to 1.8.2 on my Samsung Galaxy M01 (Android 12). It is not working on either the Inbox page or the Email view.

Thank you.

KristhianX commented 1 day ago

Hello! Thank you for your reply and patience. Could you please try disabling other extensions to ensure there are no conflicts? If the problem still persists, please let me know, and I will add an option or button in the next update to log the result of the code so you can send me those logs.

Siva981 commented 1 day ago

Hi,

I believe you are onto something here. It is uBlock Origin. That is what is bothering with the scroll the functionality. When I disabled all the addons & then re-enabled EBTB alone, the scroll started working on mail.google.com to my surprise.

So turned back on the other addons one by one (I use 13) & narrowed it down to uBlock. Now I do not even have to disable uBlock altogether. Disabling it just for mail.google.com makes the scroll work again on Gmail.

That said, I'm quite not sure if it is any particular filter inside uBlock that is blocking EBTB's scroll functionality. I did unselect a few filters at a time (including My Filters), applied changes & then reloaded mail.google.com. But that did not help me identify if it is any particular filter that is causing this.

Do you need a screenshot of my uBlock's dashboard? So that you could apply all the same filters that I'm using and recreate the issue?

KristhianX commented 14 hours ago

Thank you for your reply and for taking the time to test the behavior with other add-ons disabled. I’m also a user of uBlock Origin—it’s a must-have!

I was busy today fixing some bugs from the last update. Please provide a screenshot or detail any changes you’ve made to the default uBlock settings, especially those that apply to Gmail, and I’ll investigate it tomorrow.