search

KristjanESPERANTO / MMM-ISS-Live

Displays live video from the International Space Station on your MagicMirror².
MIT License
6 stars 0 forks source link

Heads Up, Upcoming change to cookie behavior for chrome and electron might break module #4

Open Kayakbabe opened 5 months ago

Kayakbabe commented 5 months ago

Google owns youtube and they are making a change to Cookie handling in about two weeks or so. There are cross site cookies for the iss-live module that are currently showing warnings in my MagicMirror. So I suspect that the cookie could be an issue if suddenly the module stops showing videos in the next few weeks.

Here is the js warning in my electron console. 

Cookie set in cross-site context will be blocked in future Chrome versions
In a future version of the browser, cookies marked with SameSite=None; Secure and not Partitioned will be blocked in cross-site context. This behavior protects user data from cross-site tracking.
Please refer to the article linked to learn more about preparing your site to avoid potential breakage.
1 cookie
Name    Domain & Path
YSC .youtube.com/
KristjanESPERANTO commented 5 months ago

Thanks for the heads up! :slightly_smiling_face: I'm concentrating on other projects at the moment, but as soon as the time comes and the module no longer works, I'll take a look.

Do you perhaps already have a suggestion on how to solve it?

Kayakbabe commented 5 months ago

I'm no where near as talented as you. My skills are hammering on existing code to beat it into the shape I need. This seems a little beyond me at the moment. But I thought I'd document this issue since I read about it and I think it's going to affect a lot of our modules, indeed a lot of old code on the newer version of raspberry pi Os.

KristjanESPERANTO commented 5 months ago

I appreciate you calling me talented 😊 But I think I just spent more time hammering on code 😉

I think it's going to affect a lot of our modules

It would be sad if that happened and we didn't get it solved. Let's wait and see. I leave this issue open as a reminder.