search

KristjanESPERANTO / MagicMirror-3rd-Party-Modules

This project provides an overview of all MagicMirror² modules and puts the modules through a few tests.
https://kristjanesperanto.github.io/MagicMirror-3rd-Party-Modules/
MIT License
13 stars 4 forks source link

How to add tags? #22

Closed dathbe closed 3 months ago

dathbe commented 3 months ago

Is there a way for users to add tags, or is that only available for devs/automatic? For example, the MMM-MyScoreboard module has the tag sports, but not sport, which means it does not come up when you filter using the sport button in the menu bar.

dathbe commented 3 months ago

I see now that the tags are pulled from the package.json keywords. I would suggest letting the Sport tag also pull in any Sports keywords. It's an American English/British English distinction.

KristjanESPERANTO commented 3 months ago

Good advice! :smiley: What would you recommend as the main tag sport or sports?

I could merge both or we create PRs to harmonize that.

Now sports is used one time and sport is used four times.

dathbe commented 3 months ago

"Sports" is what I use. But I think most of the rest of the world uses "sport". Is there a way to grab "sport*" and label it one or the other? I don't care what it's labeled, but American devs will tend toward listing "sports" and others "sport". You'll have a hard time getting everyone to be consistent.

KristjanESPERANTO commented 3 months ago

Okay, I have just implemented that the keyword "Sport" is replaced by "Sports" :runner: :slightly_smiling_face: