search

KristjanESPERANTO / MagicMirror-3rd-Party-Modules

This project provides an overview of all MagicMirror² modules and puts the modules through a few tests.
https://kristjanesperanto.github.io/MagicMirror-3rd-Party-Modules/
MIT License
13 stars 4 forks source link

MMM-Multimonth License issues? #30

Closed BKeyport closed 1 month ago

BKeyport commented 1 month ago

Per your issues page, My license info is all messed up - can you look at my package.json and figure out why? It seems saying my license is NOASSERTION - should be "MIT-Modern-Variant"

Thanks.

BKeyport commented 1 month ago

Nevermind, I just noticed it's looking for the LICENSE file, not LICENSE.md

KristjanESPERANTO commented 1 month ago

My script uses the GitHub API and not the LICENSE file directly. NOASSERTION means that GitHub does not recognize the license from the license file text. Under which license do you want to publish your module?

BKeyport commented 1 month ago

I actually was going to reopen this later today. I like the MIT-Modern-Variant

On Mon, May 13, 2024 at 1:38 AM Kristjan ESPERANTO @.***> wrote:

My script uses the GitHub API and not the LICENSE file directly. NOASSERTION means that GitHub does not recognize the license from the license file text. Under which license do you want to publish your module?

— Reply to this email directly, view it on GitHub https://github.com/KristjanESPERANTO/MagicMirror-3rd-Party-Modules/issues/30#issuecomment-2106979389, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKVL3DA7FXKRF5X7PLHOXMDZCB3ZPAVCNFSM6AAAAABHRIUGSKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMBWHE3TSMZYHE . You are receiving this because you modified the open/close state.Message ID: <KristjanESPERANTO/MagicMirror-3rd-Party-Modules/issues/30/2106979389@ github.com>

BKeyport commented 1 month ago

Status: Still broken.

LICENSE file: 

Copyright © 2020-2025 Brendan Keyport. All rights reserved.

Permission is hereby granted, without written agreement and without license or royalty fees, to use, copy, modify, and distribute this software and its documentation for any purpose, provided that the above copyright notice and the following two paragraphs appear in all copies of this software.

IN NO EVENT SHALL BRENDAN KEYPORT et al.  BE LIABLE TO ANY PARTY FOR DIRECT, INDIRECT, SPECIAL, INCIDENTAL, OR CONSEQUENTIAL DAMAGES ARISING OUT OF THE USE OF THIS SOFTWARE AND ITS DOCUMENTATION, EVEN IF BRENDAN KEYPORT et al  HAS BEEN ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.

BRENDAN KEYPORT et al. SPECIFICALLY DISCLAIMS ANY WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE. THE SOFTWARE PROVIDED HEREUNDER IS ON AN "AS IS" BASIS, AND BRENDAN KEYPORT et al.  HAS NO OBLIGATION TO PROVIDE MAINTENANCE, SUPPORT, UPDATES, ENHANCEMENTS, OR MODIFICATIONS.

https://spdx.org/licenses/MIT-Modern-Variant.html it the template I used.

For purposes of the package.json file I got the license list link from: https://docs.npmjs.com/cli/v6/configuring-npm/package-json#license

KristjanESPERANTO commented 1 month ago

Somehow I feel that the modern MIT version is worse than the classic one...

Please try my PR. It could be the year, the double spaces and/or the ‘et al.’.

KristjanESPERANTO commented 1 month ago

Saddly I doubt that this solved the problem. The title still only says Licence and not MIT licence as in the MagicMirror repo.

I'm afraid this is a GitHub problem. GitHub doesn't seem to recognise the MIT-Modern-Variant yet.

bildo

bildo

BKeyport commented 1 month ago

Alright, it's switched over to the MIT regular license (Grumble)

KristjanESPERANTO commented 1 month ago

Okay, now MIT is also displayed for your module 🙂. Too bad that GitHub can't handle the "modern" version yet.