search

KristjanESPERANTO / MagicMirror-3rd-Party-Modules

This project provides an overview of all MagicMirror² modules and puts the modules through a few tests.
https://kristjanesperanto.github.io/MagicMirror-3rd-Party-Modules/
MIT License
13 stars 4 forks source link

Improve CSS #6

Closed KristjanESPERANTO closed 4 months ago

KristjanESPERANTO commented 4 months ago

Reported by @Fabrizz :

About the page, in mobile the card are smaller than the screen width, some icons are not shown.

In desktop I would have a max width for the card container, as if the screen is too big it would just expand.

bugsounet commented 4 months ago

Hi Kristjan, I see that sort menu is not displayed on an mobile page I don't know if it's related to CSS or main core.

In all case good job ! it is now embed into the MMM-GoogleAssistant website :)

KristjanESPERANTO commented 4 months ago

Thanks for the feedback! I've just improved a few details for the mobile version :smiley:

With this I close the issue for now. If you notice anything else about the styling, please let me know here or in a new issue.

it is now embed into the MMM-GoogleAssistant website :)

That's really cool! Thank you :slightly_smiling_face:

Fabrizz commented 4 months ago

Im changing a bit the cards so the images are not that big, will create the pr

image
KristjanESPERANTO commented 4 months ago

I like it! Thanks in advance! :smiley:

Would be nice if you would also add a before-screenshot in the PR.

KristjanESPERANTO commented 4 months ago

Since @Fabrizz made some changes by PR #7 I close this issue :slightly_smiling_face: