search

KristofferC / Crayons.jl

Colored and styled strings for terminals.
Other
150 stars 14 forks source link

Revert "Only print escape sequences if IO supports" #29

Closed KristofferC closed 5 years ago

KristofferC commented 5 years ago

Reverts KristofferC/Crayons.jl#25

This turned out to unfortunately be too annoying in practice. For example, it means we cannot support string interpolation which is a very convenient use of this package.

CC @ronisbr

codecov-io commented 5 years ago

Codecov Report

Merging #29 into master will increase coverage by 0.26%. The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #29      +/-   ##
==========================================
+ Coverage   87.32%   87.58%   +0.26%     
==========================================
  Files           8        8              
  Lines         284      282       -2     
==========================================
- Hits          248      247       -1     
+ Misses         36       35       -1
Impacted Files Coverage Δ
src/crayon.jl 90% <50%> (+0.78%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update fbd677f...90a823e. Read the comment docs.

ronisbr commented 5 years ago

Yes, indeed. Please, revert this while I think if there is a way to avoid that.