search

KristofferC / Crayons.jl

Colored and styled strings for terminals.
Other
150 stars 14 forks source link

Julia 1.0 support #63

Open davidanthoff opened 2 years ago

davidanthoff commented 2 years ago

I noticed that Crayons.jl recently bumped the min Julia to 1.6. We have a dependency on Crayons in the VS Code extension (via JuliaFormatter.jl), and our plan is to keep supporting Julia 1.0 for the foreseeable future [*]. Was there a specific reason to drop Julia 1.0 support, or was it just done because why-not? Is there a chance that we could keep supporting Julia 1.0?

[*] The long term plan is that once static compilation can produce small enough binaries that we ship a compiled version of the language server in the VS Code extension, and at that point the code in the LS will no longer have to run on legacy Julia versions, it will then just need to be able to consume legacy Julia code.

KristofferC commented 2 years ago

People on pre 1.6 will just use the old Crayons that supports 1.0 then? Not sure why it was dropped, maybe I wanted to use some syntax that was not available in 1.0 or just save some cycles by not running CI on it.

davidanthoff commented 2 years ago

Crayons is one of the packages we vendor in the VS Code extension, we do that for all the packages that the language server needs. So, we need to pick one version for everyone. For now, I just pinned Crayons to the last version that also supports 1.0. That should work until one of our deps in the chain bumps their min version of Crayons... I think at the moment it is pulled in via JuliaFormatter->CommonMarkdown->Crayons.