search

KristofferC / OhMyREPL.jl

Syntax highlighting and other enhancements for the Julia REPL
https://kristofferc.github.io/OhMyREPL.jl/latest/
Other
746 stars 57 forks source link

Noticeable lag when importing with ProgressLogging.jl #316

Closed mkschleg closed 1 year ago

mkschleg commented 1 year ago

I'm noticing that there is considerable lag in the REPL when importing OhMyREPL.jl and ProgressLogging.jl on julia 1.9-rc1. The lag isn't in import, but the REPL hangs quite a bit after the second package is loaded (it doesn't matter which order).

Using:

ProgressLogging v0.1.4
OhMyREPL v0.5.20
jakobnissen commented 1 year ago

I see 136 invalidations in JuliaSyntax when loading ProgressLogging and 493 invalidations total, compared to 356 invalidations total when not loading OhMyREPL. I also experience this myself when loading JSON3. Unfortunately, https://github.com/timholy/SnoopCompile.jl/issues/354 prevents me from finding the source.

The invalidations don't seem to happen from loading just JuliaSyntax, only in conjunction with OhMyREPL.

mkschleg commented 1 year ago

Seems to be fixed in RC2. So I'm closing.