search

KristofferC / OhMyREPL.jl

Syntax highlighting and other enhancements for the Julia REPL
https://kristofferc.github.io/OhMyREPL.jl/latest/
Other
768 stars 60 forks source link

Add JuliaSyntax-0.4 as a compatible version #323

Closed c42f closed 1 year ago

c42f commented 1 year ago

Also fix #313, fix #315

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage has no change and project coverage change: +0.29 :tada:

Comparison is base (243ef61) 56.59% compared to head (b412a45) 56.88%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #323 +/- ## ========================================== + Coverage 56.59% 56.88% +0.29% ========================================== Files 15 15 Lines 1115 1111 -4 ========================================== + Hits 631 632 +1 + Misses 484 479 -5 ``` | [Impacted Files](https://app.codecov.io/gh/KristofferC/OhMyREPL.jl/pull/323?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Kristoffer+Carlsson) | Coverage Δ | | |---|---|---| | [src/repl.jl](https://app.codecov.io/gh/KristofferC/OhMyREPL.jl/pull/323?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Kristoffer+Carlsson#diff-c3JjL3JlcGwuamw=) | `13.12% <0.00%> (+0.17%)` | :arrow_up: | ... and [2 files with indirect coverage changes](https://app.codecov.io/gh/KristofferC/OhMyREPL.jl/pull/323/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Kristoffer+Carlsson)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

KristofferC commented 1 year ago

Thanks!

Also, just as a long shot, I wonder if I could nerd snipe you about https://github.com/KristofferC/OhMyREPL.jl/issues/315#issue-1642682951 which claims a regression sneaked in in https://github.com/KristofferC/OhMyREPL.jl/commit/1bc0e5b7ec9e1a9b294e0ffc5ff651a2294a69e1. Since only the tokenizer was swapped out I wonder what the difference between Tokenize.jl vs JuliaSyntax.jl could be...

If you are not biting, no worries, I'll get to it at some point :).

c42f commented 1 year ago

Ok I had a look at #315, thinking it could be due to the different way JuliaSyntax tokenizes whitespace inside triple quotes. Turns out that wasn't it at all, the call to untokenize_with_ANSI was just missing the indent argument after the refactoring in #277.

Anyway, I've fixed it here.

KristofferC commented 1 year ago

Turns out that wasn't it at all, the call to untokenize_with_ANSI was just missing the indent argument after the refactoring in https://github.com/KristofferC/OhMyREPL.jl/pull/277.

Oh wow... Thanks a lot for finding that.