search

KristofferC / OhMyREPL.jl

Syntax highlighting and other enhancements for the Julia REPL
https://kristofferc.github.io/OhMyREPL.jl/latest/
Other
746 stars 57 forks source link

syntext highlighting in 1.11 #342

Open KronosTheLate opened 4 months ago

KronosTheLate commented 4 months ago

The new julia stdlib JuliaSyntaxHighlighting will be introduced in 1.11:

A new standard library for applying syntax highlighting to Julia code, this uses JuliaSyntax and StyledStrings to implement a highlight function that creates an AnnotatedString with syntax highlighting applied.

Is this expected to collide with OhMyREPL in any way? Or perhaps it is the first step to integrate OhMyREPL functionality into base? In any case, a comment on the syntax highlighting introduced in 1.11 would be nice in the readme.

KristofferC commented 3 months ago

Is this expected to collide with OhMyREPL in any way?

Not until it is enabled in the REPL. Once it is and it works as well or better as what we have in OMR, we remove the highlight functionality from this package. We could also look into using that package for the syntax highlighting in OMR but the fact that all "passes" (like bracket highlight etc) builds open the same tokenizer make things quite nice and composable.

KronosTheLate commented 3 months ago

Great, so it seems like you have though of it over here. Feel free to close this, or keep it around until this has in fact been dealt with.