KristofferC / OhMyREPL.jl

Syntax highlighting and other enhancements for the Julia REPL
https://kristofferc.github.io/OhMyREPL.jl/latest/
Other
746 stars 57 forks source link

Add ability to disable auto double quotes matching #346

Open pbouffard opened 2 months ago

pbouffard commented 2 months ago

This creates a workaround for #334. On Julia 1.10 and later the default is to disable OhMyREPL's matching of string literal delimiters (a.k.a double quotes ") , and this can be manually done on any Julia version with enable_autocomplete_string_literals(false), which is exported as with the existing enable_autocomplete_brackets.

codecov-commenter commented 2 months ago

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 56.18%. Comparing base (b0071f5) to head (d172105).

Files Patch % Lines
src/BracketInserter.jl 0.00% 2 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #346 +/- ## ========================================== - Coverage 56.27% 56.18% -0.09% ========================================== Files 15 15 Lines 1123 1123 ========================================== - Hits 632 631 -1 - Misses 491 492 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

BoundaryValueProblems commented 1 month ago

I hope this pull request will be processed very soon since this is a good idea. I just want to disable the autocompletion of " mark but want to keep the autocompletion of brackets!

Yuan-Ru-Lin commented 1 month ago

Just want to comment on the possibility of adding an option to disable autocompletion of single quotes (') as well. I have found myself typing ' for adjoint and having to delete the additional one given by autocompletion. It would be useful when creating a Char like 'a' but this happens less frequently than adjoint.

axsk commented 6 days ago

I am not sure if this needs to be an option. I would rather have it disabled by default and reduce configuration complexity.