search

KristofferC / PGFPlotsX.jl

Plots in Julia using the PGFPlots LaTeX package
Other
301 stars 40 forks source link

Change `filename::String` to `filename::AbstractString` #174

Closed tamasgal closed 5 years ago

tamasgal commented 5 years ago

This is a tiny change which widens the type space of filename. I ran into the issues multiple times that split creates strings of type SubString{String} which cannot be passed as filename in e.g. pgfsave.

codecov-io commented 5 years ago

Codecov Report

Merging #174 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #174   +/-   ##
=======================================
  Coverage   87.31%   87.31%           
=======================================
  Files           9        9           
  Lines         536      536           
=======================================
  Hits          468      468           
  Misses         68       68
Impacted Files Coverage Δ
src/tikzpicture.jl 100% <ø> (ø) :arrow_up:
src/build.jl 93.1% <ø> (ø) :arrow_up:
src/axislike.jl 95.12% <ø> (ø) :arrow_up:
src/tikzdocument.jl 72.54% <ø> (ø) :arrow_up:
src/axiselements.jl 94.76% <ø> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4bedfc2...80ec0a7. Read the comment docs.

tpapp commented 5 years ago

A simple test just checking that a non-String passes through the calls OK would also be useful. Just saving something trivial as a pdf file, check test/test_build.jl.

tamasgal commented 5 years ago

I'll add that, I had some troubles running the test suite ;)

tamasgal commented 5 years ago

Alright, I added a test using .tex to minimise the overhead.