KristofferC commented 4 years ago

Need to check that the showable works so that e.g. IJulia will show a png if we don't have an svg converter available.

This caches the result of the external package lookup, perhaps we shouldn't even do that...

Fixes https://github.com/KristofferC/PGFPlotsX.jl/issues/160

tpapp commented 4 years ago

This caches the result of the external package lookup, perhaps we shouldn't even do that...

I kind of agree, lookup on demand should be very cheap (compared to the cost of rendering an actual plot).

tpapp commented 4 years ago

Incidentally, if Julia 1.0 fails because of some issue with that is tricky to resolve, I am OK with dropping support for that.

codecov-io commented 4 years ago

Codecov Report

Merging #187 into master will decrease coverage by 2.39%. The diff coverage is 70%.

@@            Coverage Diff            @@
##           master     #187     +/-   ##
=========================================
- Coverage   87.31%   84.92%   -2.4%     
=========================================
  Files           9        9             
  Lines         536      577     +41     
=========================================
+ Hits          468      490     +22     
- Misses         68       87     +19

Impacted Files	Coverage Δ
src/PGFPlotsX.jl	`90.47% <ø> (ø)`	:arrow_up:
src/build.jl	`72.22% <64.44%> (-20.89%)`	:arrow_down:
src/tikzdocument.jl	`71.52% <74.54%> (-1.03%)`	:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 77122f5...491a9c8. Read the comment docs.

KristofferC commented 4 years ago

Trid this in IJulia with all the different combinations of availablility of png / svg renderers. Seems to work fine.

KristofferC / PGFPlotsX.jl

remove build step and find external packages lazily during runtime #187

Codecov Report