Closed KristofferC closed 4 years ago
Merging #188 into master will decrease coverage by
4.09%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## master #188 +/- ##
=========================================
- Coverage 86.63% 82.53% -4.1%
=========================================
Files 9 9
Lines 591 567 -24
=========================================
- Hits 512 468 -44
- Misses 79 99 +20
Impacted Files | Coverage Δ | |
---|---|---|
src/axislike.jl | 80.48% <0%> (-17.08%) |
:arrow_down: |
src/options.jl | 80% <0%> (-10%) |
:arrow_down: |
src/PGFPlotsX.jl | 80.95% <0%> (-9.53%) |
:arrow_down: |
src/axiselements.jl | 93.02% <0%> (-2.33%) |
:arrow_down: |
src/tikzdocument.jl | 68.87% <0%> (-0.67%) |
:arrow_down: |
src/requires.jl | 100% <0%> (ø) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 1b4d1e0...7948cca. Read the comment docs.
Preview: https://kristofferc.github.io/PGFPlotsX.jl/previews/PR188.
With dark theme, the pictures are pretty hard to see (perhaps need to make them have a solid background like we do in IDEs):
The logo could be generated in SVG, then just converted to PNG with a tool that can preserve transparency.
Incidentally, I think that committing the logo to the repo and just using a relative link would be nice.
I guess that article#documenter-page
should work for Documenter 0.24 HTML as a selector.
I have some time to work on this now. OK if I push into this branch?
@KristofferC, do you have the source for the logo? Can we perhaps put it in the repository, maybe even the manual? It is kind of neat.
I dont think I have the original julia code that produced it but the example was taken from https://texwelt.de/fragen/7436/drehtransformation-mit-pgfplots/7839 (scroll down a bit) with the latex code
\documentclass[border=10pt]{standalone}
\usepackage{pgfplots}
\begin{document}
\begin{tikzpicture}
\begin{axis}[axis equal]
\addplot3[
surf,
domain = 0:360,
y domain = 0:360,
samples = 100,
samples y = 70,
z buffer = sort,
colormap/cool,
]
( {(6+(sin(3*(x+3*y))+1.25)*cos(x))*cos(y)},
{(6+(sin(3*(x+3*y))+1.25)*cos(x))*sin(y)},
{((sin(3*(x+3*y))+1.25)*sin(x))} );
\end{axis}
\end{tikzpicture}
\end{document}
Logo and variations are done in #205.
I have merged the logo from #205, fixed the CSS for Documenter 0.24, and made image backgrounds white (in CSS, seemed the simplest thing to do).
@KristofferC, please look at the output and let me know if there is anything else we need to do before merging.
This is what it looks like now (in Chromium, Firefox is the same):
@KristofferC, ok if I merge this? I think all outstanding issues were resolved.
Does the custom CSS really work? I thought with the new Documenter you had to "compile" the new CSS somehow. Anyway, we can still merge this if it looks OK.
My understanding is that it is copied from the assets. I will merge, and then if there are problems I will fix them.
Yes, it works (looks the same as the screenshot above).
The HTML generated by the new documenter is just nicer in general.
TODO: