search

KristofferC / PGFPlotsX.jl

Plots in Julia using the PGFPlots LaTeX package
Other
301 stars 40 forks source link

Fix VLine and HLine for log axis. #194

Closed korsbo closed 4 years ago

korsbo commented 4 years ago

Fixes #193 

julia> @pgf ax = Axis({ymode="log", xmode="log"},
           PlotInc(
               Expression("x^2"),
           ),
           VLine(1.),
           HLine(5.),
           )

demo

and it still works fine with linear axes: demo2

KristofferC commented 4 years ago

Nice!

korsbo commented 4 years ago

Aah, I see that the test needs updating too.

codecov-io commented 4 years ago

Codecov Report

Merging #194 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #194   +/-   ##
=======================================
  Coverage   84.92%   84.92%           
=======================================
  Files           9        9           
  Lines         577      577           
=======================================
  Hits          490      490           
  Misses         87       87
Impacted Files Coverage Δ
src/axiselements.jl 94.76% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 640649c...910e456. Read the comment docs.

tpapp commented 4 years ago

Very neat, thanks!