KristofferC / PGFPlotsX.jl

Plots in Julia using the PGFPlots LaTeX package

Other

301 stars 40 forks source link

enable CompatHelper via Github actions #202

Closed tpapp closed 4 years ago

tpapp commented 4 years ago

following https://github.com/bcbi/CompatHelper.jl/#installation

codecov-io commented 4 years ago

Codecov Report

Merging #202 into master will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #202   +/-   ##
=======================================
  Coverage   85.37%   85.37%           
=======================================
  Files           9        9           
  Lines         581      581           
=======================================
  Hits          496      496           
  Misses         85       85

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 37a2458...bcbe8bc. Read the comment docs.

tpapp commented 4 years ago

@KristofferC, OK if we merge this and enable CompatHelper?

KristofferC commented 4 years ago

Yeah, but I think what will happen is that the docs/Manifest will be updated to the latest version which will pull in the newest Documenter where our custom CSS doesn't work. But we can see.

KristofferC commented 4 years ago

There shouldn't be a need to enable any bot, right?

tpapp commented 4 years ago

My understanding is that there is no bot, just this "action".

I am not sure if the project in docs touched at all by CompatHelper. But we can always put compat bounds there.

KristofferC commented 4 years ago

But we can always put compat bounds there.

But the point of CompatHelper is to loosen bounds so not sure that will be effective. Anyway, we will see.