search

KristofferC / PGFPlotsX.jl

Plots in Julia using the PGFPlots LaTeX package
Other
301 stars 40 forks source link

use the Tables.jl interface instead of DataFrames.jl #234

Closed tpapp closed 4 years ago

tpapp commented 4 years ago

Many packages now implement this abstract interface, and it could serve as the fallback for TableData, simplifying the code a lot. Specifically,

  1. the entry point could be a single TableData(table; scanlines = 0, rowsep = ROWSEP)
  2. which could use eg a row-based schema
  3. users could input an AbstractMatrix, a vector of NamedTuples, a NamedTuple of vectors in place of the methods currently used by the package,
  4. we would get integration with all related packages out of the box.

We could just depend on Tables.jl as it is rather lightweight, alleviating #227.

tpapp commented 4 years ago

I am happy to write this, just wanted to discuss first as it is a breaking API change, and would require that we bump to 2.0. I made #233 so that the users who want to wait before updating get a working version in the meantime.

KristofferC commented 4 years ago

Why does it have to be a breaking change?