search

KristofferC / PGFPlotsX.jl

Plots in Julia using the PGFPlots LaTeX package
Other
301 stars 40 forks source link

update VSCode detection #273

Closed KristofferC closed 3 years ago

pfitzseb commented 3 years ago

Technically this should also check whether the plot pane even is enabled. Would probably be best if VSCode passes an appropriate IOContext attribute to all show methods it calls?

KristofferC commented 3 years ago

Technically this should also check whether the plot pane even is enabled

Probably yes. Is there a good way to do that?

pfitzseb commented 3 years ago

Yes, check VSCodeServer.PLOT_PANE_ENABLED[].

tpapp commented 3 years ago

I don't have much to add as I don't use VSCode, but does the new code work with older versions likely to be around in the wild? Or should check for both symbols and ||?

KristofferC commented 3 years ago

I changed it to keep the old check as well.

pfitzseb commented 3 years ago

FWIW, no post-1.0 version of the extension uses the old symbol. Can't hurt to keep the check around though.