search

KristofferC / PGFPlotsX.jl

Plots in Julia using the PGFPlots LaTeX package
Other
301 stars 40 forks source link

Horizontal and vertical bands #279

Closed CiaranOMara closed 2 years ago

CiaranOMara commented 2 years ago

I think this is ready for review. It's essentially a variant of the VLine and HLine conveniences to draw vertical and horizontal bands. I'm not sure what your preference is for order of occurrence, I've just placed code at the end of various spots.

tpapp commented 2 years ago

Looks good to me. Bands without options are just black rectangles, correct?

CiaranOMara commented 2 years ago

I hadn't considered a no options case. But, yes, they would be black rectangles. Perhaps we could do better with some sensible defaults. What about PGFPlotsX.Options(:draw=> "none", :fill=> "grey", :opacity => 0.5 )?

tpapp commented 2 years ago

I think it is fine as is (we try to keep PGFPlotsX as a very thin wrapper), I was just curious.