search

KristofferC / PGFPlotsX.jl

Plots in Julia using the PGFPlots LaTeX package
Other
301 stars 40 forks source link

Handle missing values for `Coordinates` #285

Closed KeitaNakamura closed 2 years ago

KeitaNakamura commented 2 years ago

This PR makes Coordinates handle missings:

julia> Plot(Coordinates([1,2,3], [4,5,missing]))

julia> Plot(Coordinates([(1,4), (2,5), (3,missing)]))
KeitaNakamura commented 2 years ago

I'm sorry if this is a feature. Using NaN seems to be supported already, but I think missing is also standard for invalid value in Julia. For example, in CSV package, an empty field is parsed as the missing by default. So it would be very useful if this package supports missing.

KristofferC commented 2 years ago

I think this makes sense, yes. @tpapp, any opinions?

tpapp commented 2 years ago

I think this is fine, but I am away from my laptop and won't be able to review in detail for a while.