search

KristofferStrube / Blazor.FileSystemAccess

A Blazor wrapper for the File System Access browser API.
https://kristofferstrube.github.io/Blazor.FileSystemAccess/
MIT License
327 stars 39 forks source link

NuGet and check API availability #4

Closed Enfis closed 2 years ago

Enfis commented 2 years ago

Hello Kristoffer, great wrapper!

Are you planning to add this wonderful library to NuGet?

An "isSupported" method will be great as well, I don't know exactly if some browsers will add partial support to this API later...

Thank you, best regards

KristofferStrube commented 2 years ago

Hey @Enfis 🙂

I plan to plublish to Nuget in next week.

Good idea with the isSupported() method. Will have to look into how that can be done.

KristofferStrube commented 2 years ago

Hey @Enfis, I have added the IsSupported() method now.

Enfis commented 2 years ago

You did a great job!

Just a suggestion ... if you wish to add futher classes, like a wrapper for the .NET Stream class, please leave "lower-levels" classes (like FileSystemWritableFileStream) public, don't make them private.

Cheers 😉👍

KristofferStrube commented 2 years ago

FileSystemWritableFileStream is public, with protected properties, but an internal constructor.

I think that should be fine for extensibility while still concealing the constructor that is not part of the API.

KristofferStrube commented 2 years ago

Hey @Enfis It is now on Nuget: https://www.nuget.org/packages/KristofferStrube.Blazor.FileSystemAccess/ 😁