search

KristopherKubicki / glimpser

a simple tool for real-time monitoring video and summarization with LLMs
http://glimpser.net
MIT License
14 stars 1 forks source link

Implement graceful shutdown and improve thread handling #206

Closed sweep-ai[bot] closed 2 months ago

sweep-ai[bot] commented 2 months ago

This pull request was created by Sweep to resolve the following request by @KristopherKubicki:

it still doesnt shut down clean on control c.

Error capturing screenshot for https://map.blitzortung.org/#4.72/42.06/-87.41 Scheduler is not running 127 Process ForkProcess-8: Process ForkProcess-6: Traceback (most recent call last): File "./main.py", line 152, in Process ForkProcess-1: Process ForkProcess-4: Process ForkProcess-7: app.run(host=config.HOST, port=config.PORT, debug=config.DEBUG_MODE, threaded=True) File "/home/kristopher/code/glimpser/env/lib/python3.8/site-packages/flask/app.py", line 625, in run run_simple(t.cast(str, host), port, self, **options) File "/home/kristopher/code/glimpser/env/lib/python3.8/site-packages/werkzeug/serving.py", line 1116, in run_simple srv.serve_forever() File "/home/kristopher/code/glimpser/env/lib/python3.8/site-packages/werkzeug/serving.py", line 810, in serve_forever super().serve_forever(poll_interval=poll_interval) File "/usr/lib/python3.8/socketserver.py", line 232, in serve_forever ready = ...

Continue chatting at https://sweep-chat-demo.vercel.app/c/0a2ffc37-18fe-46bf-aadb-e9bd01ff9d1a.

Purpose

This pull request aims to implement a graceful shutdown mechanism for the Glimpser application and improve the handling of non-daemon threads.

Description

The changes in this pull request include:

  1. Implementing a graceful shutdown process for the application:

    • Added a graceful_shutdown function in app/__init__.py that handles the shutdown process, including terminating non-daemon threads and shutting down the scheduler.
    • Registered a signal handler for the SIGINT (Ctrl+C) signal in main.py to initiate the graceful shutdown process.

  2. Improving the handling of non-daemon threads:

    • Modified the graceful_shutdown function to use the join method to terminate non-daemon threads, instead of relying on the terminate method, which may not be available for all thread types.
    • Added error handling to the thread termination process to gracefully handle any exceptions that may occur.

  3. Refactoring the scheduler setup:

    • Created a custom GracefulAPScheduler class in app/utils/scheduling.py that extends the APScheduler class and provides a more robust shutdown process.
    • Updated the scheduler initialization in app/__init__.py to use the new GracefulAPScheduler class.

Summary

The key changes in this pull request include:

coderabbitai[bot] commented 2 months ago

[!WARNING]

Rate limit exceeded

@sweep-ai[bot] has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 26 minutes and 7 seconds before requesting another review.

How to resolve this issue? After the wait time has elapsed, a review can be triggered using the `@coderabbitai review` command as a PR comment. Alternatively, push new commits to this PR. We recommend that you space out your commits to avoid hitting the rate limit.
How do rate limits work? CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our [FAQ](https://coderabbit.ai/docs/faq) for further information.
Commits Files that changed from the base of the PR and between 3a19aa68ab2f07c56d915988651962f6dc3c2edc and acc2587820128971284caf5ccf8554de504f1736.

[!TIP]

Early access features: enabled We are currently testing the following features in early access: - **Anthropic `claude-3-5-sonnet` for code reviews**: The new Claude model has stronger code understanding and code generation capabilities than the previous models. We're excited to hear your feedback as we evaluate its performance over the next few days. Note: - You can enable or disable early access features from the CodeRabbit UI or by updating the CodeRabbit configuration file. - Please join our [Discord Community](https://discord.com/invite/GsXnASn26c) to provide feedback and report issues on the [discussion post](https://discordapp.com/channels/1134356397673414807/1279579842131787838).

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
github-actions[bot] commented 2 months ago

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Manifest Files