Kritika30032002 / Blog_Website

This is a blog website where user can compose their blogs. The blogs are saved in database.

https://blog-tui6.onrender.com/

25 stars 61 forks source link

[feat] Added in blog-site #153

Open PranjaliBhardwaj opened 3 months ago

PranjaliBhardwaj commented 3 months ago

108 #152 all overlapping of footer from all pages are fixed and signup with google OAuth credentials is also added in the signup page,

After: Screenshot 2024-03-22 170754 Before: Screenshot 2024-03-22 124216 I have removed firebase config details due to security reasons, but I am also beginner and don't know if its okay, so if it is I can add those details too. @Kritika30032002

Kritika30032002 commented 3 months ago

adding
for space is not a good practice. Look into another way.

Kritika30032002 commented 3 months ago

also you should have separate pr for separate issue

PranjaliBhardwaj commented 3 months ago

@Kritika30032002 That issue wasn't that big so I didn't create a new pull request, but for future I will keep that in mind. I have used css now to avoid overlapping of footer and other page's content.

Kritika30032002 commented 3 months ago

see the highlighted code line

PranjaliBhardwaj commented 3 months ago

see the highlighted code line

So I should use margin instead to spaces?

Kritika30032002 commented 3 months ago

yes

PranjaliBhardwaj commented 3 months ago

now its good. @Kritika30032002 Thankyou for your guidance and patience.