search

Kroc / elite-harmless

Disassembly (CA65) of the Commodore 64 port of the seminal space-sim Elite, by Ian Bell / David Braben.
https://discord.gg/ZYnQr5S
Other
93 stars 12 forks source link

Fails to build on case-preserving filesystems #60

Closed majick closed 1 year ago

majick commented 1 year ago

A file named code_28BA.asm is not the same thing as a file named code_28ba.asm on most filesystems (unless you go out of your way to mount them in an case-insensitive way, but this can break a lot of other things!) and therefore the build fails.

Renaming the file to code_28ba.asm fixes the build. Changing the include would also do it, but it's not exactly best practice to use caps in hexadecimal filenames if possible. Keeping filenames lowercase is probably ideal, but renaming all the others and fixing those includes is probably the best and most portable eventual thing.

I could send over a PR to tidy this up if that would be helpful?

Kroc commented 1 year ago

Thank you for the spot -- please send a PR so that your contribution can be properly recorded in the repository history!