search

Kromster80 / kam_remake

"KaM Remake" is an RTS game remake written in Delphi from scratch.
http://www.kamremake.com
GNU Affero General Public License v3.0
361 stars 90 forks source link

Campaign nodes animate backwards in some places #275

Open lewinjh opened 7 years ago

lewinjh commented 7 years ago

@Alexandr57 Since ordering didn't matter previously, some campaigns have the nodes in the wrong order causing them to animate backwards (TSK 1 for example).

We need two things:

  1. Campaign builder needs a way to rearrange nodes (move up/down buttons or dragging).

  2. All 4 campaigns included in KaM Remake need to be checked that the nodes animate in the correct direction and if not they need fixing (and info.cmp files committed). Ideally this should be done while maintaining the exact positions of existing nodes, by reordering using point 1 above rather than moving the nodes around (so nodes stay in EXACTLY the same position as intended by the campaign author).

@Alexandr57 Since animating nodes was your PR, can you please implement these two changes?

Alexandr57 commented 7 years ago

@lewinjh 1 - I'm sorry. I can not carry the movement through the up and down buttons 2 - Yes. This is done as soon as: https://github.com/Kromster80/kam_remake/pull/256 It will be in the master branch. All that I have a different idea of displacement. Namely move by right-clicking the mouse. Kromster80 But this idea is not approved. So this idea I do for themselves And then tinkering Nodes campaigns

I can also make the numbering flags and nodes in Campaign builder. However, with the numbering of the nodes have a small problem in terms of efficiency

Alexandr57 commented 7 years ago

https://github.com/Kromster80/kam_remake/pull/303

lewinjh commented 7 years ago

Thanks!

Alexandr57 commented 7 years ago

Hey. This course is closed but I have to report that there is an unofficial version of CB Developer The ability to move the node by right-clicking the mouse I am trying to persuade chrome approved at PR. It's only developer functions. For registered users there is support to disable these functions In short I think the code will be dismantled. https://github.com/Alexandr57/kam_remake/tree/Changing_Nodes_And_Flags_Places

lewinjh commented 7 years ago

Right clicking is not an intuitive interface for rearranging nodes. Dragging to rearrange in the treeview (or even move up/down buttons) would be better.

Alexandr57 commented 7 years ago

I'm aware of but on the other can not, and that's why this development function For users, they will not be available

lewinjh commented 7 years ago

Why "can not"?

And why do we need to have this development function if we've already fixed the campaigns? Will we ever use it again?

Alexandr57 commented 7 years ago

@lewinjh I beg your pardon very large. Fix nodes that I sent it turned out trash. And all because of my carelessness. A bug in the program. It is not correct numbers the nodes. Bug tinkering and I throw off the new PR. And if you can roll back if the PR: https://github.com/Kromster80/kam_remake/pull/303

lewinjh commented 7 years ago

Rolled back in #320. Please send a corrected PR.

Alexandr57 commented 7 years ago

@lewinjh Here you are: https://github.com/Kromster80/kam_remake/pull/323

Alexandr57 commented 7 years ago

https://github.com/Kromster80/kam_remake/pull/323

Alexandr57 commented 6 years ago

The old PR is closed because the branch is not working. New PR already with all the corrections - https://github.com/Kromster80/kam_remake/pull/430