Kromtec / LegendsViewer

Recreates Dwarf Fortress' Legends Mode from exported files.
GNU General Public License v3.0
62 stars 19 forks source link

Creature Race Names not displaying #53

Closed geouk1 closed 4 years ago

geouk1 commented 4 years ago

The "races" drop down menu isn't diplaying the subfilter catagories correctly. It seems like they are all there, but their names haven't registered. Instead, for each one it simply says: "LegendsViewer.Legends.CreatureInfo"

Don't know if this is a general bug or because of my world (haven't modded or changed anything about the game). I'm playing on 0.47.04, with DFHack 0.47.04-r1.

Any idea about what's going on?

Thanks so much for your work buddy. I spend so much time on Legend's Viewer, sometimes more than the actual game I love it so much! Screenshot (41)

JakeTrans commented 4 years ago

Hi,

First off to echo geouk1 Thanks for making this I started using this years ago and it open my eyes to how detailed the world is.

I think I've found the cause of the issue, I believe it is due to the race becoming a object rather than a string. I took a fork and was able to get the race to show with a few tweaks. Would it be useful if I was to resubmit a pull request with my changes?

Thanks again for all your work,

Jake

Kromtec commented 4 years ago

Hi Jake,

of course it would be useful. Feel free to make a pull request, but please to the 'develop' branch and not directly to 'master'. I am on vacation the next few days, so I might not be able to react quickly.

Thank you for tackling this issue!

JakeTrans commented 4 years ago

I've raised the pull request, let me know if there any problems, it's the first time I've done this.

have a nice vacation.

Thanks,

Kromtec commented 4 years ago

You did everything correct. 😃 I will close the issue with the next release.