search

Kromtec / LegendsViewer

Recreates Dwarf Fortress' Legends Mode from exported files.
GNU General Public License v3.0
62 stars 19 forks source link

A crash in the most recent version #58

Closed 0xa08ab242 closed 3 years ago

0xa08ab242 commented 3 years ago

Hi, I got this error when trying to import my world after using dfhack export legends info (and later when retrying using export legends all)

This is the popup: crash_popup

Here is a copy/paste of the "exception text" (in case the image doesn't show enough): See the end of this message for details on invoking just-in-time (JIT) debugging instead of this dialog box.

** Exception Text ** System.FormatException: Input string was not in a correct format. at System.Number.StringToNumber(String str, NumberStyles options, NumberBuffer& number, NumberFormatInfo info, Boolean parseDecimal) at System.Number.ParseInt32(String s, NumberStyles style, NumberFormatInfo info) at LegendsViewer.Legends.Events.MasterpieceArch..ctor(List1 properties, World world) at LegendsViewer.Legends.Parser.XmlParser.AddEvent(String type, List1 properties) at LegendsViewer.Legends.Parser.XmlParser.AddItemToWorld(List`1 properties) at LegendsViewer.Legends.Parser.XmlParser.ParseSection() at LegendsViewer.Legends.Parser.XmlParser.Parse() at LegendsViewer.Legends.World..ctor(BackgroundWorker worker, String xmlFile, String historyFile, String sitesAndPopulationsFile, String mapFile, String xmlPlusFile) at LegendsViewer.FileLoader.BackgroundWorkerOnDoWork(Object sender, DoWorkEventArgs e) at System.ComponentModel.BackgroundWorker.OnDoWork(DoWorkEventArgs e) at System.ComponentModel.BackgroundWorker.WorkerThreadStart(Object argument)

I am also attaching the exported files... ...bumping up the against the 10MB attachment size limit, will try splitting the zip into 3 files below the limit... (with 1 per message in 2 responses/comments following this). legends-Eternals-00426-06-12.001.zip

Thanks

0xa08ab242 commented 3 years ago

here's the second part of the zip legends-Eternals-00426-06-12.002.zip

0xa08ab242 commented 3 years ago

and finally, here is the third part of the zip legends-Eternals-00426-06-12.003.zip

I should add that I had to rename the files to for github to allow me to upload them... for 7zip to read them correctly and merge them together, they need to be renamed as follows: legends-Eternals-00426-06-12.zip.001 legends-Eternals-00426-06-12.zip.002 legends-Eternals-00426-06-12.zip.003

Thanks again

narolol commented 3 years ago

I'm having the same exact problem. While troubleshooting I confirmed that the issue happens while reading the 'plus' XML file. If you delete it, Legends Viewer will load up with no other issues.

Hope this helps!

JakeTrans commented 3 years ago

Running it myself it looks like some of the items are expected to be numbers but are represented as words now. might have been a change in the makeup of the 'Plus' XML file.

Kromtec commented 3 years ago

Thanks for bringing this to my attention. As JakeTrans already suspected, the new version of DFHack has changed a property from a number to a text and that caused the crash. I have fixed it in the development branch and will close this ticket as soon as I make a new release.

Kromtec commented 3 years ago

fixed in v.1.20.06b Hotfix release